All the public functions and the classes in the PR contain docstrings that explain what it does.In case of new functionality, my PR adds documentation that describes how to use it.Body explains "what" and "why", not "how".Subject uses the imperative mood ("add", not "adding").Subject is limited to 50 characters (not including Jira issue reference).Subject is separated from body by a blank line.In addition, my commits follow the guidelines from " How to write a good git commit message": My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue.My PR adds the following unit tests OR does not need testing for this extremely good reason:.Some switching between upstream/downstream calls here and there because of the now correct behaviour.Correctly implementing the definition root and leaf nodes.Also, to my surprise there weren't even tests for these basic properties, so I added 3 tests verifying the behaviour of roots and leaves. I've also implemented a leaves property to make a clear distinction between first/starting nodes and last/finishing nodes. This PR aligns the Airflow implementation of a "root" node with DAG literature. Or, as literature also explains it: root nodes are nodes without upstream dependencies, while it was implemented as nodes without downstream dependencies. The Airflow codebase is extremely confusing because the concept "root" node in Airflow is actually implemented as the last, finishing node of a DAG, while in DAG literature root nodes are the first nodes to execute. Here are some details about my PR, including screenshots of any UI changes:.In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy. ![]() ![]() In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal ( AIP).In case you are fixing a typo in the documentation you can prepend your commit with, code changes always need a Jira issue.My PR addresses the following Airflow Jira issues and references them in the PR title.Make sure you have checked all steps below.
0 Comments
Leave a Reply. |
AuthorWrite something about yourself. No need to be fancy, just an overview. ArchivesCategories |